Skip to content

builder: use proper percentage calculations for default gc policy#51125

Merged
thaJeztah merged 1 commit intomoby:masterfrom
jsternberg:gcpolicy-invalid-calculations
Oct 7, 2025
Merged

builder: use proper percentage calculations for default gc policy#51125
thaJeztah merged 1 commit intomoby:masterfrom
jsternberg:gcpolicy-invalid-calculations

Conversation

@jsternberg
Copy link
Copy Markdown
Collaborator

@jsternberg jsternberg commented Oct 7, 2025

The default gc policy calculations based on percentage were calculated
improperly. These were calculated correctly in buildkit, but the
calculation method was not copied over correctly when updating the
values.

Fixes #51122.

@jsternberg
builder: use proper percentage calculations for default gc policy
1a7d7cc 
The default gc policy calculations based on percentage were calculated
improperly. These were calculated correctly in buildkit, but the
calculation method was not copied over correctly when updating the
values.

Signed-off-by: Jonathan A. Sternberg <[email protected]>
@thaJeztah thaJeztah mentioned this pull request Oct 7, 2025
Closed
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Oct 7, 2025

Failures are unrelated and known flaky tests;

=== Failed
=== FAIL: amd64.docker.docker.integration.networking TestBridgeICC/IPv6_ULA_on_internal_network (4.57s)
    firewall.go:69: Firewalld reload completed at 2025-10-07T16:44:42Z
    bridge_linux_test.go:218: assertion failed: 1 (res.ExitCode int) != 0 (int)
    bridge_linux_test.go:220: assertion failed: string "PING ctr-icc-3-1 (fdf1:a844:380c:b247::2): 56 data bytes\n\n--- ctr-icc-3-1 ping statistics ---\n1 packets transmitted, 0 packets received, 100% packet loss\n" does not contain "1 packets transmitted, 1 packets received"
    --- FAIL: TestBridgeICC/IPv6_ULA_on_internal_network (4.57s)

=== FAIL: amd64.docker.docker.integration.networking TestBridgeICC/IPv6_link-local_address_on_internal_network (4.56s)
    firewall.go:69: Firewalld reload completed at 2025-10-07T16:44:49Z
    bridge_linux_test.go:218: assertion failed: 1 (res.ExitCode int) != 0 (int)
    bridge_linux_test.go:220: assertion failed: string "PING fe80::2%eth0 (fe80::2): 56 data bytes\n\n--- fe80::2%eth0 ping statistics ---\n1 packets transmitted, 0 packets received, 100% packet loss\n" does not contain "1 packets transmitted, 1 packets received"
    --- FAIL: TestBridgeICC/IPv6_link-local_address_on_internal_network (4.56s)

=== FAIL: amd64.docker.docker.integration.networking TestBridgeICC (30.19s)

@thaJeztah thaJeztah merged commit 104d26b into moby:master Oct 7, 2025
267 of 270 checks passed
@thaJeztah thaJeztah mentioned this pull request Oct 7, 2025
Merged
@jsternberg jsternberg deleted the gcpolicy-invalid-calculations branch October 8, 2025 14:16
@thaJeztah thaJeztah added this to the 29.0.0 milestone Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazy-max crazy-max crazy-max approved these changes

@robmry robmry robmry approved these changes

Assignees

No one assigned

Labels

area/builder/buildkit Build area/builder Build kind/bugfix PR's that fix bugs process/cherry-picked status/4-merge

Projects

None yet

Milestone

29.0.0

Development

Successfully merging this pull request may close these issues.

Invalid MaxUsedSpace and MinFreeSpace calculations for default GC policy

4 participants

@jsternberg @thaJeztah @crazy-max @robmry