Skip to content

ci: update gha cache attributes#51118

Merged
thaJeztah merged 1 commit intomoby:masterfrom
crazy-max:ci-cache-fixes
Oct 7, 2025
Merged

ci: update gha cache attributes#51118
thaJeztah merged 1 commit intomoby:masterfrom
crazy-max:ci-cache-fixes

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented Oct 7, 2025

  • mode=max is not necessary since we update bake-action to v6 and therefore is using git context so git metadata don't invalidate the cache anymore.
  • firewalld dev image was not built as prepare step, seems to be an oversight so adds it to the matrix.

Should be backported to other branches.

- A picture of a cute animal (not mandatory but encouraged)

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Oct 7, 2025

mode=max is not necessary since we update bake-action to v6 and therefore is using git context so git metadata don't invalidate the cache anymore.

Should the action have a linter / warning when this option is set with v6 (or higher)? I can imagine people have this option set, but no longer needing it; would be nice if the action would print a warning for them to remove it from their config.

@thaJeztah thaJeztah merged commit 86c418f into moby:master Oct 7, 2025
301 of 303 checks passed
@thaJeztah
Copy link
Copy Markdown
Member

@crazy-max can you open cherry-picks for 28.x (and 25.0) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants