Add existence check for go.mod and go.sum files#51093
Conversation
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
added
kind/bugfix
|
@thaJeztah , @vvoland , do you folks have any thoughts if I should be checking the same for api and client module files? Wrote just the top level for now so this can more easily backported to 28.x release branch. |
dmcgowan
left a comment
dmcgowan
left a comment
There was a problem hiding this comment.
LGTM
I think its worth exploring if there is a more generic alternative to this, I don't see why missing vendors shouldn't produce an error or diff after running tidy + vendor. Any diff after those operations should fail.
Ah! Found your "ping" - saw a notification and ... couldn't find it back 😂 Yeah, I think I added something like that in #50947 as well; basically to always run a |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
let's get this one in as stepping stone
3 participants
- What I did
Follow-up to #51090
- How I did it
Added a check for top-level go.mod and go.sum files exist.
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)