Skip to content

[28.x] Add back vendor.sum#51091

Merged
austinvazquez merged 1 commit intomoby:28.xfrom
austinvazquez:add-vendor-sum-to-28.x
Oct 3, 2025
Merged

[28.x] Add back vendor.sum#51091
austinvazquez merged 1 commit intomoby:28.xfrom
austinvazquez:add-vendor-sum-to-28.x

Conversation

@austinvazquez
Copy link
Copy Markdown
Contributor

@austinvazquez austinvazquez commented Oct 2, 2025

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Austin Vazquez <[email protected]>
@austinvazquez austinvazquez marked this pull request as ready for review October 2, 2025 22:32
@austinvazquez austinvazquez added this to the 28.5.1 milestone Oct 3, 2025
@austinvazquez austinvazquez self-assigned this Oct 3, 2025
@cyphar
Copy link
Copy Markdown
Contributor

cyphar commented Oct 3, 2025

Is there a chance of adding a CI job or check in the existing validate jobs to make sure this doesn't accidentally happen again?

@thaJeztah
Copy link
Copy Markdown
Member

Yes, we're looking at that; there is a vendor check, but we're looking why it didn't flag this issue. Also, GitHub actions had issues around the time that PR was merged, and it looks like it may have skipped checks; see #51075 (comment)

We may have two add a similar hack as runc added to work around the horrible way of GitHub actions for these.

@thaJeztah
Copy link
Copy Markdown
Member

@cyphar are you able to work around this in your pipeline? FWIW, we are looking into a regression in the BuildKit version included in v28.5.0, and BuildKit will be doing a patch release on Monday (after the weekend); moby/buildkit#6261

@cyphar
Copy link
Copy Markdown
Contributor

cyphar commented Oct 3, 2025

I've just applied this patch to our packages for now so it's not really a pressing issue.

@thaJeztah
Copy link
Copy Markdown
Member

Thanks, that's good to hear!

@austinvazquez
Copy link
Copy Markdown
Contributor Author

Bringing this in. I'm working on the check so it doesn't happen again in #51093 and will backport it all supported branches.

@austinvazquez austinvazquez merged commit 5c2c3c2 into moby:28.x Oct 3, 2025
318 of 328 checks passed
@austinvazquez austinvazquez deleted the add-vendor-sum-to-28.x branch October 3, 2025 20:27
@thaJeztah
Copy link
Copy Markdown
Member

Ah, yes! I kicked CI because it failed on the cache issue, didn't see it finished 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants