Skip to content

[28.x] vendor: github.com/moby/buildkit v0.25.0-rc1#51032

Merged
vvoland merged 2 commits intomoby:28.xfrom
vvoland:51029-28.x
Sep 24, 2025
Merged

[28.x] vendor: github.com/moby/buildkit v0.25.0-rc1#51032
vvoland merged 2 commits intomoby:28.xfrom
vvoland:51029-28.x

Conversation

@vvoland
Copy link
Copy Markdown
Contributor

@vvoland vvoland commented Sep 24, 2025

full diff: moby/buildkit@v0.24.0...v0.25.0-rc1

Update BuildKit to [v0.25.0-rc1](https://github.com/moby/buildkit/releases/tag/v0.25.0-rc1)

@vvoland vvoland added this to the 28.5.0 milestone Sep 24, 2025
@vvoland vvoland self-assigned this Sep 24, 2025
@vvoland vvoland added area/builder Build kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. impact/changelog area/builder/buildkit Build labels Sep 24, 2025
thaJeztah
thaJeztah requested changes Sep 24, 2025
View reviewed changes
Comment thread vendor.mod Outdated
Comment on lines +9 to +10

toolchain go1.24.7
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the toolchain directive?

also looks like it's missing a cherry-picked-from comment in the commit message

Copy link
Copy Markdown
Contributor Author

@vvoland vvoland Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed toolchain

Copy link
Copy Markdown
Contributor Author

@vvoland vvoland Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I actually didn't cherry-pick because of the go.mod vs vendor.mod difference

vvoland and others added 2 commits September 24, 2025 16:26
@vvoland
vendor: github.com/moby/buildkit v0.25.0-rc1
22e0cb2 
full diff: moby/buildkit@v0.24.0...v0.25.0-rc1

Signed-off-by: Paweł Gronowski <[email protected]>
@tonistiigi @vvoland
hack: use custom ref for buildkit tests
80ac399 
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Paweł Gronowski <[email protected]>
(cherry picked from commit e8d3609)
Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland vvoland requested a review from thaJeztah September 24, 2025 14:27
@vvoland vvoland marked this pull request as ready for review September 24, 2025 15:03
@vvoland vvoland requested a review from tianon as a code owner September 24, 2025 15:03
thaJeztah
thaJeztah approved these changes Sep 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland
Copy link
Copy Markdown
Contributor Author

vvoland commented Sep 24, 2025 


=== Failed
=== FAIL: frontend/dockerfile TestIntegration/TestSSHFileDescriptorsClosed/worker=dockerd/frontend=client (11.48s)
    dockerfile_ssh_test.go:130: ssh-agent failed to start: OpenSSL version mismatch. Built against 3050003f, you have 30500010
    sandbox.go:202: stdout: /usr/bin/dockerd
    sandbox.go:202: stderr: /usr/bin/dockerd
    sandbox.go:205: > startCmd 2025-09-24 15:18:07.940392053 +0000 UTC m=+349.659850461 /usr/bin/dockerd --data-root /tmp/integration3413044973/d74bmuxu2af67/root --exec-root /tmp/dxr/d74bmuxu2af67 --pidfile /tmp/integration3413044973/d74bmuxu2af67/docker.pid --containerd-namespace d74bmuxu2af67 --containerd-plugins-namespace d74bmuxu2af67p --host unix:///tmp/docker-integration/d74bmuxu2af67.sock --config-file /tmp/integration3413044973/daemon.json --tls=false --debug --userland-proxy=false

2nd failure of this one

@vvoland
Copy link
Copy Markdown
Contributor Author

vvoland commented Sep 24, 2025

I will get this one in since it's an upstream alpine issue unrelated to the PR

@vvoland vvoland merged commit d21856f into moby:28.x Sep 24, 2025
214 of 220 checks passed
@vvoland vvoland added area/dependencies and removed kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. labels Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@austinvazquez austinvazquez austinvazquez approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees

@vvoland vvoland

Labels

area/builder/buildkit Build area/builder Build area/dependencies

Projects

None yet

Milestone

28.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vvoland @thaJeztah @austinvazquez @tonistiigi