api/docs: remove temporary "full" example for image config#50910
Merged
thaJeztah merged 2 commits intomoby:masterfrom Sep 5, 2025
Merged
api/docs: remove temporary "full" example for image config#50910thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
0cbbe8e to
302d7b7
Compare
302d7b7 to
974b5a9
Compare
Member
Author
|
Actually; learned that the swagger considers the default to be omit-empty? I can drop the last 2 commits (or keep them for later); #50855 (comment) |
This example was added in 5e0e34f so that the deprecated fields could be omitted from the example. Those fields were removed from the swagger in 4dc961d, but the temporary example was not removed. This patch removes the example, in favor of the per-field examples, which were already in place. Signed-off-by: Sebastiaan van Stijn <[email protected]>
….51) This example was added in 5e0e34f so that the deprecated fields could be omitted from the example. Those fields were removed from the swagger in 4dc961d, but the temporary example was not removed. This patch removes the example, in favor of the per-field examples, which were already in place. Signed-off-by: Sebastiaan van Stijn <[email protected]>
974b5a9 to
0fe1af9
Compare
dmcgowan
approved these changes
Sep 5, 2025
austinvazquez
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
api/docs: remove temporary "full" example for image config
This example was added in 5e0e34f so that
the deprecated fields could be omitted from the example. Those fields were
removed from the swagger in 4dc961d, but
the temporary example was not removed.
This patch removes the example, in favor of the per-field examples, which
were already in place.
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)