Create github.com/moby/moby/api and github.com/moby/moby/client module#50280
Merged
thaJeztah merged 6 commits intomoby:masterfrom Jul 21, 2025
Merged
Create github.com/moby/moby/api and github.com/moby/moby/client module#50280thaJeztah merged 6 commits intomoby:masterfrom
thaJeztah merged 6 commits intomoby:masterfrom
Conversation
dmcgowan
force-pushed
the
api-go-mod
branch
6 times, most recently
from
73d6977 to
30ca98f
Compare
Member
Author
|
The validation doesn't seem to handle the go modules, I imagine we explicitly turn off the environment variable. Validation will currently fail if the submodules require a testing library that the main module doesn't use. We can probably solve this in the future once the other modules are complete, in the meantime, #50317 fixes the validation. The gocompat had similar issues but we shouldn't need it after this since api and client will be the supported packages. |
Member
Author
|
Also see #50318 |
dmcgowan
changed the title
dmcgowan
force-pushed
the
api-go-mod
branch
2 times, most recently
from
f33eae5 to
5de6ee4
Compare
crazy-max
reviewed
Jul 10, 2025
dmcgowan
force-pushed
the
api-go-mod
branch
3 times, most recently
from
c3c52d1 to
57c5046
Compare
17 tasks
austinvazquez
approved these changes
Jul 16, 2025
Contributor
austinvazquez
left a comment
austinvazquez
left a comment
There was a problem hiding this comment.
🎉 wow, looks clean.
thaJeztah
requested changes
Jul 18, 2025
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
I need to have a closer look before going ahead
These tests don't account well for submodules and are not needed when importers are using go modules. The tests are still relevant in the 28 branch which does not use go modules. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
This was referenced Jul 21, 2025
Member
|
Opened draft PRs to test this; compose looks to be broken due to a change in buildx? |
github-project-automation
Bot
moved this from In Progress
to Done
in go modules transition
This was referenced Aug 4, 2025
This was referenced Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a go module from the api directory and uses it in the main module.
Note: first just testing this out, we can figure out how to automate the replace similar to what was done in containerd later. At least having a command for
go mod edit -replace=github.com/moby/moby/api=./apiDepends on #50278