fix staticcheck linting issues for golangci-lint v2#49885
Merged
thaJeztah merged 15 commits intomoby:masterfrom May 1, 2025
Merged
fix staticcheck linting issues for golangci-lint v2#49885thaJeztah merged 15 commits intomoby:masterfrom
thaJeztah merged 15 commits intomoby:masterfrom
Conversation
vvoland
added
area/testing
kind/refactor
thaJeztah
reviewed
Apr 28, 2025
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Thank you! I went through these per-commit, and left suggestion on some of them; if possible, could you amend those commits (if changes are made)?
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
… == -1 Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
…..)) Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
approved these changes
May 1, 2025
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I did a quick rebase and squashed the review comments commit with the related commits.
Signed-off-by: Matthieu MOREL <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
Member
|
Ah, good that I did; looks like there was a change that didn't cause a conflict, but made the build fail because of a rename; |
Member
|
Whoop, all green; bringing this one in 🎉 |
mmorel-35
pushed a commit
to mmorel-35/moby
that referenced
this pull request
May 1, 2025
fix staticcheck linting issues for golangci-lint v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes staticcheck linting issues for golangci-lint v2
Related to #49870
- How I did it
Enable a staticcheck rule at a time, fix it and create a dedicated commit.
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)