Skip to content

API: /info: remove BridgeNfIptables, BridgeNfIp6tables fields#49783

Merged
vvoland merged 1 commit intomoby:masterfrom
thaJeztah:deprecate_bridgenfip_fields
Apr 11, 2025
Merged

API: /info: remove BridgeNfIptables, BridgeNfIp6tables fields#49783
vvoland merged 1 commit intomoby:masterfrom
thaJeztah:deprecate_bridgenfip_fields

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Apr 10, 2025

The BridgeNfIptables and BridgeNfIp6tables fields in the GET /info response were deprecated in API v1.48, and are now omitted in API v1.49.

With this patch, old API version continue to return the field:

curl -s --unix-socket /var/run/docker.sock http://localhost/v1.48/info | jq .BridgeNfIp6tables
false

curl -s --unix-socket /var/run/docker.sock http://localhost/v1.48/info | jq .BridgeNfIptables
false

Omitting the field in API v1.49 and above

curl -s --unix-socket /var/run/docker.sock http://localhost/v1.49/info | jq .BridgeNfIp6tables
null

curl -s --unix-socket /var/run/docker.sock http://localhost/v1.49/info | jq .BridgeNfIptables
null

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Deprecated: The `BridgeNfIptables` and `BridgeNfIp6tables` fields in the `GET /info` response were deprecated in API v1.48, and are now omitted in API v1.49.

- A picture of a cute animal (not mandatory but encouraged)

The `BridgeNfIptables` and `BridgeNfIp6tables` fields in the
`GET /info` response were deprecated in API v1.48, and are now omitted
in API v1.49.

With this patch, old API version continue to return the field:

    curl -s --unix-socket /var/run/docker.sock http://localhost/v1.48/info | jq .BridgeNfIp6tables
    false

    curl -s --unix-socket /var/run/docker.sock http://localhost/v1.48/info | jq .BridgeNfIptables
    false

Omitting the field in API v1.49 and above

    curl -s --unix-socket /var/run/docker.sock http://localhost/v1.49/info | jq .BridgeNfIp6tables
    null

    curl -s --unix-socket /var/run/docker.sock http://localhost/v1.49/info | jq .BridgeNfIptables
    null

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@vvoland vvoland added this to the 28.1.0 milestone Apr 11, 2025
@vvoland vvoland merged commit f3d6830 into moby:master Apr 11, 2025
167 of 168 checks passed
@thaJeztah thaJeztah deleted the deprecate_bridgenfip_fields branch April 11, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants