pkg/atomicwriter: New(): prevent creating temp-file on errors, and use absolute paths#49607
Merged
vvoland merged 2 commits intomoby:masterfrom Mar 10, 2025
Merged
Conversation
The temp-file was created before trying to make the given filename an absolute path. Reverse the order of code so that we don't create a temp-file if an error happens. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Use an absolute path for both the temp-file and the destination-file. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This was referenced Mar 9, 2025
vvoland
approved these changes
Mar 10, 2025
Member
Author
|
Thx! I have a bunch of updates after this; after testing some scenarios with this package, there were some fun corner-cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/atomicwriter: New(): prevent creating temp-file on errors
The temp-file was created before trying to make the given filename an
absolute path. Reverse the order of code so that we don't create
a temp-file if an error happens.
pkg/atomicwriter: New(): use absolute path for temp-file
Use an absolute path for both the temp-file and the destination-file.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)