switch to github.com/opencontainers/cgroups#49562
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Mar 24, 2025
Merged
Conversation
thaJeztah
force-pushed
the
switch_cgroups
branch
2 times, most recently
from
2ce2e6f to
f1fa233
Compare
thaJeztah
force-pushed
the
switch_cgroups
branch
2 times, most recently
from
4192c5d to
f0b8b37
Compare
7 tasks
thaJeztah
force-pushed
the
switch_cgroups
branch
from
f0b8b37 to
1b2f3a1
Compare
h-vetinari
reviewed
Mar 10, 2025
| github.com/opencontainers/cgroups v0.0.1 | ||
| github.com/opencontainers/go-digest v1.0.0 | ||
| github.com/opencontainers/image-spec v1.1.0 | ||
| github.com/opencontainers/runc v1.2.5 |
There was a problem hiding this comment.
This reminds me of an old issue of mine, which can probably be closed already, but definitely after this PR? 🤔
Member
Author
There was a problem hiding this comment.
Not directly related; that ticket is more related to packaging (and http://github.com/docker/containerd-packaging). This is only a build-dependency on some of the Go libraries provided by runc.
thaJeztah
force-pushed
the
switch_cgroups
branch
from
1b2f3a1 to
26d2ef0
Compare
thaJeztah
force-pushed
the
switch_cgroups
branch
from
26d2ef0 to
cc0a1f9
Compare
The runc libcontainer/cgroups package was moved to a separate module; switch our use of the runc module to use the new location. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
switch_cgroups
branch
from
cc0a1f9 to
4db84b1
Compare
vvoland
approved these changes
Mar 24, 2025
AkihiroSuda
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on / stacked:
switch to github.com/opencontainers/cgroups
The runc libcontainer/cgroups package was moved to a separate
module; switch our use of the runc module to use the new
location.
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)