vendor: github.com/moby/buildkit v0.20.0#49495
Merged
Merged
Conversation
full diff: moby/buildkit@v0.20.0-rc3...v0.20.0 Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
added
status/2-code-review
impact/changelog
area/builder/buildkit
thaJeztah
reviewed
Feb 19, 2025
| Timeout: c.Timeout, | ||
| Client: tracing.DefaultClient, | ||
| Timeout: c.Timeout, | ||
| UserAgent: bkversion.UserAgent(), |
Member
There was a problem hiding this comment.
Saw the user agent was added; does the user agent and/or should it be matching "docker engine" or "buildkit"? @jsternberg @tonistiigi
Member
There was a problem hiding this comment.
This is the same user-agent used for registry requests and ADD. The value is configurable by the importer (but unrelated to this PR).
Member
There was a problem hiding this comment.
Ah, thanks; wasn't sure if it's something we had do wire up to pass through our user-agent.
(but perhaps something for a future release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: moby/buildkit@v0.20.0-rc3...v0.20.0
Signed-off-by: Paweł Gronowski [email protected]