pkg/idtools: un-deprecate Windows consts for now#49405
Merged
vvoland merged 1 commit intomoby:masterfrom Feb 6, 2025
Merged
Conversation
These consts were deprecated in 9c368a9, but are used externally and lack a canonical location. These sids are "special", as they are available by default in Windows containers, but we need to; - Reference official documentation / specification for that. - Add names (not just the sid) - Consider finding a canonical location for these consts, which could be as part of the OCI specs, or hcsshim (or otherwise). Lacking a good place for these, let's un-deprecate them for the time being until we decided what's the best location for these. Signed-off-by: Sebastiaan van Stijn <[email protected]>
vvoland
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These consts were deprecated in 9c368a9, but are used externally and lack a canonical location. These sids are "special", as they are available by default in Windows containers, but we need to;
Lacking a good place for these, let's un-deprecate them for the time being until we decided what's the best location for these.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)