implement missing "Unwrapper" interface on errors that implemented "Causer" interface#49390
Merged
vvoland merged 3 commits intomoby:masterfrom Feb 5, 2025
Merged
implement missing "Unwrapper" interface on errors that implemented "Causer" interface#49390vvoland merged 3 commits intomoby:masterfrom
vvoland merged 3 commits intomoby:masterfrom
Conversation
This error implemented the Causer interface, but did not implement the go1.13 unwrapper, which could prevent errors from being matched. Signed-off-by: Sebastiaan van Stijn <[email protected]>
2 tasks
These errors implemented the Causer interface, but did not implement the go1.13 unwrapper, which could prevent errors from being matched. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
implement_unwrapper
branch
from
1316544 to
1d9cc84
Compare
This error implemented the Causer interface, but did not implement the go1.13 unwrapper, which could prevent errors from being matched. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
implement_unwrapper
branch
from
1d9cc84 to
294df1c
Compare
vvoland
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cluster/executor/container: exitError: implement go1.13 unwrapper
This error implemented the Causer interface, but did not implement
the go1.13 unwrapper, which could prevent errors from being matched.
volumes/service: OpErr: implement go1.13 unwrapper
This error implemented the Causer interface, but did not implement
the go1.13 unwrapper, which could prevent errors from being matched.
distribution: fallbackError, notFoundError implement go1.13 unwrapper
These errors implemented the Causer interface, but did not implement
the go1.13 unwrapper, which could prevent errors from being matched.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)