Implement GwAllocChecker for the remote network driver#49372
Merged
robmry merged 1 commit intomoby:masterfrom Feb 5, 2025
Merged
Implement GwAllocChecker for the remote network driver#49372robmry merged 1 commit intomoby:masterfrom
robmry merged 1 commit intomoby:masterfrom
Conversation
robmry
added
kind/feature
Member
|
/cc @aepifanov |
aepifanov
approved these changes
Jan 31, 2025
akerouanton
reviewed
Feb 4, 2025
Member
akerouanton
left a comment
akerouanton
left a comment
There was a problem hiding this comment.
Code LGTM but /libnetwork/docs/remote.md needs to be updated
Commit 38e76eb (Ask network drivers if they'll use a gateway address) added an optional driver interface "GwAllocChecker" to give the driver a chance to say whether, given network config options, it would use a gateway address if one was reserved for it in IPAM. So, implement support for that in the remote network driver. The driver itself implements the interface, but only tries to make an HTTP request to the driver plugin if the plugin has reported support for it in response to an initial capabilities request. Signed-off-by: Rob Murray <[email protected]>
robmry
force-pushed
the
remote_driver_skip_gw_alloc
branch
from
cd05dc9 to
6349514
Compare
Contributor
Author
Ah - yes! Thank you, I've added some words. |
akerouanton
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Commit 38e76eb (Ask network drivers if they'll use a gateway address) added an optional driver interface "GwAllocChecker" to give the driver a chance to say whether, given network config options, it would use a gateway address if one was reserved for it in IPAM.
So, implement support for that in the remote network driver.
- How I did it
The remote driver itself implements the interface, but only tries to make an HTTP request to the driver plugin if the plugin has reported support for it in response to an initial capabilities request.
- How to verify it
New test.
- Description for the changelog