daemon: remove Daemon.children(), Daemon.parents() wrappers#49369
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jan 30, 2025
Merged
daemon: remove Daemon.children(), Daemon.parents() wrappers#49369thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
Remove the wrappers to make it more explicit that these are related to the legacy links feature. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Make it more clear that this loop is for legacy-links, and the timer is only needed for that purpose. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/daemon
vvoland
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daemon: remove Daemon.children(), Daemon.parents() wrappers
Remove the wrappers to make it more explicit that these are related to
the legacy links feature.
daemon: Daemon.restore: make legacy-link code conditional
Make it more clear that this loop is for legacy-links, and the timer is
only needed for that purpose.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)