api/types: remove some redundant imports#49355
Merged
vvoland merged 2 commits intomoby:masterfrom Jan 29, 2025
Merged
Conversation
It was the only use of github.com/pkg/errors inside api/types, which is the package that's imported by external users. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
It was the only use of errdefs inside api/types, which is the package that's imported by external users. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
api_types_less_deps
branch
from
a092e72 to
9b5a51a
Compare
Member
Author
|
New flaky test; Added in |
Member
Author
|
This one also remains quite flaky; |
vvoland
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api/types/registry: use stdlib errors package
It was the only use of github.com/pkg/errors inside api/types,
which is the package that's imported by external users.
api/types/container: remove use of errdefs package in test
It was the only use of errdefs inside api/types, which is the package
that's imported by external users.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)