Skip to content

client: improve test-coverage for error-responses#49354

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:client_test_coverage
Jan 30, 2025
Merged

client: improve test-coverage for error-responses#49354
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:client_test_coverage

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jan 29, 2025

- Description for the changelog



- A picture of a cute animal (not mandatory but encouraged)

    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



                    

          
        





  





    



      

  
        





      

  
            


    

    

      
    

    


      


          @thaJeztah
thaJeztah




          added this to the 
  28.0.0 milestone


      Jan 29, 2025

    

  



    

    

      
    

    


      


          @thaJeztah
thaJeztah




              self-assigned this


      Jan 29, 2025

    

  








      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Jan 29, 2025


      
    


  





      


        



  
    

      
          
I have some follow-ups to this, but let's get the tests in first


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Jan 29, 2025


      
    


  





      


        



  
    

      
          
Failure is unrelated (QEMU issue; see  #49331)


 > [smoketest 3/3] RUN <<EOT (set -ex...):
0.046 + file dockerd
0.052 dockerd: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, OpenPOWER ELF V2 ABI, version 1 (SYSV), statically linked, for GNU/Linux 3.10.0, Go BuildID=VbdbleRF64_E_QUilREH/aD2Y2AUhjhHFCxuH510D/XjPHNV9Kv2dSxEcldyPC/T7E_LTUNVmSBWkrlJeRk, BuildID[xxHash]=3e95d0055e006b87, with debug_info, not stripped
0.053 + dockerd --version
0.122 Segmentation fault (core dumped)



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  

    
  


  

      


    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Jan 29, 2025
    





  


  

      
   Merged

  







  









      

  
        





      

  
          
 
  

    
  

  



        @thaJeztah
  thaJeztah



        merged commit e7f5d73
      into

      
  
    moby:master
  


    Jan 30, 2025

  







  

  
  

  
      @thaJeztah
  thaJeztah


    
    deleted the
    
      
        client_test_coverage
    
    branch

    January 30, 2025 16:07    
    




  

  

    
  


  

      


    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Jan 30, 2025
    





  


  

      
   Merged

  







  













  
  

    

      

  










  








  
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  










      

  

    
    

    

  

    Reviewers
  


    


      

  

    


  
      @vvoland
  
    vvoland


    
      
        
      
    
    vvoland approved these changes




      






    
    
    

    

  


      
  

    Assignees
  



        


      

        


  
      @thaJeztah
  
    thaJeztah
    

      








      


  


  

    Labels
  



    

      

    area/api

  API
  

    area/testing

  

    status/2-code-review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    28.0.0
  





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
        

  

    

      2 participants
    

    

        
          @thaJeztah 
        
          @vvoland