libnetwork: remove ErrNoSuchEndpoint, ErrInvalidID, ErrInvalidName#49344
Merged
thaJeztah merged 3 commits intomoby:masterfrom Jan 27, 2025
Merged
libnetwork: remove ErrNoSuchEndpoint, ErrInvalidID, ErrInvalidName#49344thaJeztah merged 3 commits intomoby:masterfrom
thaJeztah merged 3 commits intomoby:masterfrom
Conversation
It was only returned in 1 place, and not used any different than a "notfound" error, so let's use a standard errdefs.ErrNotFound Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was only returned in a few places, and not used any different than a "invalid parameter" error, so let's use a standard errdefs.ErrInvalidParameter Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was only returned in a few places, and not used any different than a "invalid parameter" error, so let's use a standard errdefs.ErrInvalidParameter Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/networking
akerouanton
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libnetwork: remove ErrNoSuchEndpoint
It was only returned in 1 place, and not used any different than
a "notfound" error, so let's use a standard errdefs.ErrNotFound
libnetwork: remove ErrInvalidID
It was only returned in a few places, and not used any different than
a "invalid parameter" error, so let's use a standard errdefs.ErrInvalidParameter
libnetwork: remove ErrInvalidName
It was only returned in a few places, and not used any different than
a "invalid parameter" error, so let's use a standard errdefs.ErrInvalidParameter
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)