integration: remove assertAttachedStream, check both STDERR and STDOUT#49338
Merged
robmry merged 1 commit intomoby:masterfrom Jan 27, 2025
Merged
Conversation
This helper was not marked as t.Helper(), and didn't do a great job at
actually asserting the expected output streams. The existing checks
could've been replaced by a io.Readall to do a fuzzy check for the
response, but let's abstract away what it's doing, and properly check
both STDOUT and STDERR.
make BIND_DIR=. TEST_FILTER='TestTemplated' DOCKER_GRAPHDRIVER=vfs test-integration
...
INFO: Testing against a local daemon
=== RUN TestTemplatedConfig
--- PASS: TestTemplatedConfig (11.73s)
PASS
INFO: Testing against a local daemon
=== RUN TestTemplatedSecret
--- PASS: TestTemplatedSecret (11.04s)
PASS
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
robmry
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helper was not marked as t.Helper(), and didn't do a great job at actually asserting the expected output streams. The existing checks could've been replaced by a io.Readall to do a fuzzy check for the response, but let's abstract away what it's doing, and properly check both STDOUT and STDERR.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)