daemon: health: getShell: simplify logic (LCOW remnants)#49337
Merged
robmry merged 1 commit intomoby:masterfrom Jan 27, 2025
Merged
daemon: health: getShell: simplify logic (LCOW remnants)#49337robmry merged 1 commit intomoby:masterfrom
robmry merged 1 commit intomoby:masterfrom
Conversation
This function had some LCOW remnants, where the assumption was made the only on Windows, the image's OS could potentially not match the host's OS (see 3e6a13c). While we currently are not able to run a Windows image on Linux (or vice versa), this function doesn't have to take into account; - If a shell is configured; use whatever is configured - otherwise, use "cmd.exe" for Windows images, and "/bin/sh" otherwise (likely Linux, but the existing code did not account for other platforms). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/lcow
robmry
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to;
This function had some LCOW remnants, where the assumption was made the only on Windows, the image's OS could potentially not match the host's OS (see 3e6a13c).
While we currently are not able to run a Windows image on Linux (or vice versa), this function doesn't have to take into account;
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)