remove redundant uses of api/types/strslice.StrSlice#49336
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jan 27, 2025
Merged
remove redundant uses of api/types/strslice.StrSlice#49336thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
Member
Author
|
Failure looks another case of; |
robmry
approved these changes
Jan 27, 2025
| } | ||
|
|
||
| assert.Check(t, is.DeepEqual(expectedCommand, sb.state.runConfig.Cmd)) | ||
| assert.Check(t, is.DeepEqual(expectedCommand, []string(sb.state.runConfig.Cmd))) |
Contributor
There was a problem hiding this comment.
Could swap these checks around to got before want while we're at it?
Member
Author
There was a problem hiding this comment.
Ah, yes, I was considering some of that; we've not been very consistent on order (and gotest.tools is less descriptive on which one should go to the left). Let me update indeed.
Member
Author
There was a problem hiding this comment.
Updated; also push a second commit for some (all?) of the other assertions to put "expected" on the right
The only real purpose of strslice.StrSlice is to provide a custom json.Unmarshaler implementation for API responses. For all other purposes, it's a regular string-slice. This patch removes uses of this type in cases where the custom json.Unmarshaler is irrelevant; in most cases this was in tests, where results were tested using "DeepEquals"; for those tests, the type-assertion did not add real value, so we can cast the values to a []string instead. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
no_strslice
branch
from
9afa2b0 to
af9ffb6
Compare
robmry
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only real purpose of strslice.StrSlice is to provide a custom json.Unmarshaler implementation for API responses. For all other purposes, it's a regular string-slice.
This patch removes uses of this type in cases where the custom json.Unmarshaler is irrelevant; in most cases this was in tests, where results were tested using "DeepEquals"; for those tests, the type-assertion did not add real value, so we can cast the values to a []string instead.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)