libnetwork: use gotest.tools for errdefs assertions in various tests#49332
Merged
thaJeztah merged 19 commits intomoby:masterfrom Jan 27, 2025
Merged
libnetwork: use gotest.tools for errdefs assertions in various tests#49332thaJeztah merged 19 commits intomoby:masterfrom
thaJeztah merged 19 commits intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
area/networking
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
…r errdefs assertions Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
…tions Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
…or errdefs assertions Signed-off-by: Sebastiaan van Stijn <[email protected]>
…ssertions Signed-off-by: Sebastiaan van Stijn <[email protected]>
…ssertions Signed-off-by: Sebastiaan van Stijn <[email protected]>
…tions Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was only returned in 2 places, and not used any different than a "notfound" error, so let's use a standard errdefs.NotFound Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
libnetwork_use_errdefs_step3
branch
from
eada31a to
5c1fe28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)