Skip to content

libnetwork: remove some redundant type-conversions#49327

Merged
thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah:libnetwork_type_conversions
Jan 23, 2025
Merged

libnetwork: remove some redundant type-conversions#49327
thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah:libnetwork_type_conversions

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jan 22, 2025

- Description for the changelog



- A picture of a cute animal (not mandatory but encouraged)

    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



                    

          
        





  





    



      

  
        





      

  
            

    

      
    

    


      


          @thaJeztah
thaJeztah




            added
      

  status/2-code-review


      

  area/networking

  Networking

      

  kind/refactor

  PR's that refactor, or clean-up code

  labels


      Jan 22, 2025

    

  



    

    

      
    

    


      


          @thaJeztah
thaJeztah




          added this to the 
  28.0.0 milestone


      Jan 22, 2025

    

  



    

    

      
    

    


      


          @thaJeztah
thaJeztah




              self-assigned this


      Jan 22, 2025

    

  








      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Jan 22, 2025


      
    


  





      


        



  
    

      
          
Interesting; maybe not redundant? I'd expected type  conversion for these static ints to be handled correctly?


#24 0.044 + file dockerd
#24 0.050 dockerd: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, OpenPOWER ELF V2 ABI, version 1 (SYSV), statically linked, for GNU/Linux 3.10.0, Go BuildID=CSn74rD_BYZ6Z_pPYUBE/aNs5fPUO8vLFw4Dkr6JC/nBK5ylRUxaxG2d3806iZ/G2ui0cqY33rk71GIyrCE, BuildID[xxHash]=3976f7aeda41929d, with debug_info, not stripped
#24 0.051 + dockerd --version
#24 0.176 Segmentation fault (core dumped)
#24 ERROR: process "/bin/sh -c   set -ex\n  file dockerd\n  dockerd --version\n  file docker-proxy\n  docker-proxy --version\n" did not complete successfully: exit code: 139
------
 > [smoketest 3/3] RUN <<EOT (set -ex...):
0.044 + file dockerd
0.050 dockerd: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, OpenPOWER ELF V2 ABI, version 1 (SYSV), statically linked, for GNU/Linux 3.10.0, Go BuildID=CSn74rD_BYZ6Z_pPYUBE/aNs5fPUO8vLFw4Dkr6JC/nBK5ylRUxaxG2d3806iZ/G2ui0cqY33rk71GIyrCE, BuildID[xxHash]=3976f7aeda41929d, with debug_info, not stripped
0.051 + dockerd --version
0.176 Segmentation fault (core dumped)



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  
  

  
      @thaJeztah
  thaJeztah


        marked this pull request as draft

    January 22, 2025 12:25    
    




    

    

      
    

    


      


          @thaJeztah
thaJeztah




          removed this from the 
  28.0.0 milestone


      Jan 22, 2025

    

  



  

  

    
  


  

      


    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Jan 22, 2025
    





  


  

      
   Merged

  







  




  

  
  

  
      @thaJeztah
  thaJeztah


        marked this pull request as ready for review

    January 22, 2025 20:58    
    









      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Jan 22, 2025


      
    


  





      


        



  
    

      
          


Interesting; maybe not redundant? I'd expected type conversion for these static ints to be handled correctly?




Looks unrelated, and potential issues with QEMU binfmt; support for ppc64le in QEMU is still in PoC state; we should  keep an  eye though if we can get  more  info  on such failures.


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  
  

  
      @thaJeztah
  thaJeztah


          requested a review
  from robmry


    January 22, 2025 21:00    
    









      

  
        





      

  
          

  

    
  


  

      


    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Jan 23, 2025
    





  


  

      

  
  Closed

  







  









      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Jan 23, 2025


      
    


  





      


        



  
    

      
          
Opened a tracking ticket for the SEGFAULTS;



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          
 
  

    
  

  



        @thaJeztah
  thaJeztah



        merged commit c8a456a
      into

      
  
    moby:master
  


    Jan 23, 2025

  







  

  
  

  
      @thaJeztah
  thaJeztah


    
    deleted the
    
      
        libnetwork_type_conversions
    
    branch

    January 23, 2025 10:28    
    




    

    

      
    

    


      


          @thaJeztah
thaJeztah




          added this to the 
  28.0.0 milestone


      Jan 23, 2025

    

  












  
  

    

      

  










  








  
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  










      

  

    
    

    

  

    Reviewers
  


    


      

  

    


  
      @robmry
  
    robmry


    
      
        
      
    
    robmry approved these changes




      






    
    
    

    

  


      
  

    Assignees
  



        


      

        


  
      @thaJeztah
  
    thaJeztah
    

      








      


  


  

    Labels
  



    

      

    area/networking

  Networking
  

    kind/refactor

  PR's that refactor, or clean-up code
  

    status/2-code-review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    28.0.0
  





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
        

  

    

      2 participants
    

    

        
          @thaJeztah 
        
          @robmry