Revert "libnet/d/bridge: port mappings: filter by input iface"#49310
Merged
akerouanton merged 1 commit intomoby:masterfrom Jan 20, 2025
Merged
Revert "libnet/d/bridge: port mappings: filter by input iface"#49310akerouanton merged 1 commit intomoby:masterfrom
akerouanton merged 1 commit intomoby:masterfrom
Conversation
akerouanton
added
area/security
area/networking
Contributor
|
For context, this commit broke UDP networking between containers via the host mapped ports: # UDP listen on 6767
$ docker run --rm -it -p <host-ip>:6767:6767/udp busybox nc -u -lp 6767
# Send "asdf" to the above
$ docker run --rm -it busybox sh -c 'echo asdf | nc -w1 -u <host-ip> 6767'With the reverted commit, the above didn't work. -docker run --rm -it -p <host-ip>:6767:6767/udp busybox nc -u -lp 6767
+docker run --rm -it -p 6767:6767/udp busybox nc -u -lp 6767 |
vvoland
approved these changes
Jan 20, 2025
This reverts commit 433b1f9. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
force-pushed
the
revert-48721
branch
from
59257f9 to
fc7caf9
Compare
Member
|
After this one's merged, we should probably re-open #45610 (added that in the first comment) |
robmry
approved these changes
Jan 20, 2025
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Jan 22, 2025
This is a regression test for moby#49310. Signed-off-by: Albin Kerouanton <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert:
libnet/d/bridge: port mappings: filter by input iface #48721
re-opens Publishing ports explicitly to private networks should not be accessible from LAN hosts #45610
- What I did
This reverts commit 433b1f9.
#48721 prevents ports mapped on the host to be accessed by containers using the host's IP addresses:
Another use-case that might break is load-balancing clusters with floating IPs moved around, and routes to backend nodes provisioned on LB nodes as
/32(eg. IPVS + keepalived).We need to rework that fix to only filter out remote connections destined to loopback addresses.