Skip to content

spelling fix in comments (daemon/logger/loggerutils/queue.go)#49296

Merged
tonistiigi merged 1 commit intomoby:masterfrom
thompson-shaun:logjam-typo-fix
Jan 17, 2025
Merged

spelling fix in comments (daemon/logger/loggerutils/queue.go)#49296
tonistiigi merged 1 commit intomoby:masterfrom
thompson-shaun:logjam-typo-fix

Conversation

@thompson-shaun
Copy link
Copy Markdown
Contributor

@thompson-shaun thompson-shaun commented Jan 17, 2025

- What I did
Fixed 2 typos

- How I did it
Typing?

- How to verify it
Spellcheck

- Description for the changelog



- A picture of a cute animal (not mandatory but encouraged)

michael-payne-a9NQ6z1zqro-unsplash

Photo by Michael Payne on Unsplash

    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



                    

          
        





  





    



      

  
        

  

      

  
  

  
          

  

    

      


  

      
        @thompson-shaun
  




      

        
          spelling fix in comments
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          80b0570
        
      

    

  

    

      
Signed-off-by: Shaun Thompson <[email protected]>

    







  








      

  
          
    

    

      
    

    


      


          @thompson-shaun
thompson-shaun




          added this to the 
  28.0.0 milestone


      Jan 17, 2025

    

  



    

    

      
    

    


      


          @thompson-shaun
thompson-shaun




        changed the title
spelling fix in comments

spelling fix in comments (daemon/logger/loggerutils/queue.go)


      Jan 17, 2025

    

  



    







      

  
        

  

        

  thaJeztah
  

  
            

              
                    thaJeztah
  

              

              approved these changes


              
                  
                    Jan 17, 2025
                  
              
              
            


            



                
    View reviewed changes
  


            





          

  
  
  
              

                      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

    

  


  

    

      
          @thaJeztah
      

      
            thaJeztah
  

      

      

      left a comment




      
    


  



                  

                      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
LGTM

      
    

  
  




                    

                  
  
  

    
  
    
    

  

  

  



                      

                    
                  








      

  
  
  




  








      

  
        





      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Jan 17, 2025


      
    


  





      


        



  
    

      
          
Windows failures are clearly unrelated and flaky tests


=== Failed
=== FAIL: github.com/docker/docker/integration/container TestAttach/with_TTY (60.33s)
    attach_test.go:54: assertion failed: error is not nil: error during connect: Post "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.48/containers/create": EOF

=== FAIL: github.com/docker/docker/integration/container TestAttach (0.03s)

=== FAIL: github.com/docker/docker/integration/container TestRenameAnonymousContainer (10.88s)
    rename_test.go:151: assertion failed: 0 (int) != 1 (inspect.State.ExitCode int): container 6f0f1d8e87aaf26a2f5ed231cea1340abcfbc11d559a73a3bdfe9c288e21ec96 exited with the wrong exitcode: 



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          
 
  

    
  

  



        @tonistiigi
  tonistiigi



        merged commit 7e78f78
      into

      
  
    moby:master
  


    Jan 17, 2025

  
















  
  

    

      

  










  








  
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  










      

  

    
    

    

  

    Reviewers
  


    


      

  

    


  
      @thaJeztah
  
    thaJeztah


    
      
        
      
    
    thaJeztah approved these changes



      

  

    


  
      @robmry
  
    robmry


    
      
        
      
    
    robmry approved these changes



      

          


  
      @tonistiigi
  
    tonistiigi


                Awaiting requested review from tonistiigi


        
      


      






    
    
    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    kind/bugfix

  PR's that fix bugs
  

    status/4-merge









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    28.0.0
  





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
        

  

    

      4 participants
    

    

        
          @thompson-shaun 
        
          @thaJeztah 
        
          @robmry 
        
          @tonistiigi