use StatsResponse instead of Stats in tests#49284
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 16, 2025
Merged
Conversation
The StatsResponse type was a compatibility-wrapper introduced in d337994 to differentiate responses for API < 1.21 and API >= 1.21. API versions lower than 1.24 are deprecated, and we should merge StatsResponse and Stats, but let's start with using the StatsResponse in our tests. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
robmry
approved these changes
Jan 16, 2025
Contributor
robmry
left a comment
robmry
left a comment
There was a problem hiding this comment.
LGTM.
(In case it helps anyone else who's looking at this, StatsResponse was called StatsJSON when it was first added.)
Member
Author
|
oh! yes, sorry, forgot to put that in the description 🙈 it was moved and renamed, but the situation was the same still. |
Member
Author
|
I'll bring this one in; I'll be working on some of the follow-ups, but wanted to do this first to "prove" that only the outer wrapper is actually needed, and we don't need the wrapped ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The StatsResponse type was a compatibility-wrapper introduced in d337994 to differentiate responses for API < 1.21 and API >= 1.21. API versions lower than 1.24 are deprecated, and we should merge StatsResponse and Stats, but let's start with using the StatsResponse in our tests.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)