libnet/d/bridge: init driver.nlh in newDriver#49267
Merged
akerouanton merged 1 commit intomoby:masterfrom Jan 13, 2025
Merged
Conversation
This field was initialized by `driver.createNetwork` instead of being initialized by the `newDriver` constructor. That's currently the single place where it's initialized -- no tests override it, so it seems the 'current' netns is always used. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added
status/2-code-review
area/networking
robmry
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
- What I did
This field was initialized by
driver.createNetworkinstead of being initialized by thenewDriverconstructor. That's currently the single place where it's initialized -- no tests override it, so it seems the 'current' netns is always used.- How to verify it
Existing tests.