vendor: github.com/containerd/containerd/api v1.8.0#49250
Merged
tianon merged 1 commit intomoby:masterfrom Jan 10, 2025
Merged
Conversation
Member
Author
|
needed for #49251, but opening as separate PR to verify if it works without those changes as well. |
Member
Author
|
New flakiness, or legit error? Looks to have failed for two separate runs;
|
Member
Author
|
All green now, so looks like racy tests |
dmcgowan
approved these changes
Jan 10, 2025
Member
|
Actually we should probably merge this alongside the v1.7.25 change. The deprecation warnings you saw there fix a potential case where the protos were registered in two places if you had a <=v1.7.24 import alongside the 1.8 API. |
tianon
approved these changes
Jan 10, 2025
Member
Author
|
Ah, that makes sense; I can move the other one out of draft; it's just stacked on top. Let me do so! |
Member
|
So we should merge #49251 instead of this one? Or in addition to? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

full diff: https://github.com/containerd/containerd/compare/api/v1.7.19..api/v1.8.0
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)