Skip to content

vendor: github.com/containerd/containerd/api v1.8.0#49250

Merged
tianon merged 1 commit intomoby:masterfrom
thaJeztah:vendor_containerd_api_v1.8.0
Jan 10, 2025
Merged

vendor: github.com/containerd/containerd/api v1.8.0#49250
tianon merged 1 commit intomoby:masterfrom
thaJeztah:vendor_containerd_api_v1.8.0

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

full diff: https://github.com/containerd/containerd/compare/api/v1.7.19..api/v1.8.0

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Copy Markdown
Member Author

needed for #49251, but opening as separate PR to verify if it works without those changes as well.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jan 10, 2025

New flakiness, or legit error? Looks to have failed for two separate runs;

  • test / test (snapshotter) / integration (ubuntu-22.04, firewalld) (pull_request)
  • test / test (snapshotter) / integration (ubuntu-22.04, rootless) (pull_request)
=== Failed
=== FAIL: amd64.integration.container TestWaitBlocked/test-wait-blocked-exit-zero (10.36s)
    wait_test.go:95: assertion failed: 0 (tc.expectedCode int64) != 137 (waitRes.StatusCode int64)
    --- FAIL: TestWaitBlocked/test-wait-blocked-exit-zero (10.36s)

@thaJeztah
Copy link
Copy Markdown
Member Author

All green now, so looks like racy tests

@thaJeztah thaJeztah marked this pull request as ready for review January 10, 2025 13:47
@dmcgowan
Copy link
Copy Markdown
Member

Actually we should probably merge this alongside the v1.7.25 change. The deprecation warnings you saw there fix a potential case where the protos were registered in two places if you had a <=v1.7.24 import alongside the 1.8 API.

@thaJeztah
Copy link
Copy Markdown
Member Author

Ah, that makes sense; I can move the other one out of draft; it's just stacked on top. Let me do so!

@tianon
Copy link
Copy Markdown
Member

tianon commented Jan 10, 2025

So we should merge #49251 instead of this one? Or in addition to?

@tianon tianon merged commit d80e341 into moby:master Jan 10, 2025
@thaJeztah thaJeztah deleted the vendor_containerd_api_v1.8.0 branch January 10, 2025 22:36
@thaJeztah
Copy link
Copy Markdown
Member Author

LOL; I wanted to say "let me close this one otherwise it shows up as "merged" because it's the same commit 😂

2 for the price of one 🎉

Screenshot 2025-01-10 at 23 36 35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants