pkg/ioutils: deprecate unused types and functions#49244
Merged
AkihiroSuda merged 3 commits intomoby:masterfrom Jan 9, 2025
Merged
pkg/ioutils: deprecate unused types and functions#49244AkihiroSuda merged 3 commits intomoby:masterfrom
AkihiroSuda merged 3 commits intomoby:masterfrom
Conversation
These types are only used internally in container/streams and have no external consumers. Deprecate them in preparation of moving them to a subpackage of container/streams. Signed-off-by: Sebastiaan van Stijn <[email protected]>
it was moved to pkg/ioutils in c30a55f, and only had a single use at the time in [engine/Env.WriteTo]. That use was removed in 531f412, which removed the engine package. [engine/Env.WriteTo]: https://github.com/moby/moby/blob/c30a55f14dbbe3971ba0ac716ba69a60868f4490/engine/env.go#L260-L264 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Apart from being used internally for NewWriteFlusher, it's only used in a single location outside of this package. Copy the implementation where it's used, and mark it deprecated. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
impact/changelog
impact/deprecation
area/go-sdk
impact/go-sdk
This was referenced Jan 9, 2025
AkihiroSuda
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/ioutils: deprecate BytesPipe, NewBytesPipe, ErrClosed
These types are only used internally in container/streams and have no
external consumers. Deprecate them in preparation of moving them to
a subpackage of container/streams.
pkg/ioutils: deprecate WriteCounter, NewWriteCounter
it was moved to pkg/ioutils in c30a55f,
and only had a single use at the time in engine/Env.WriteTo. That use
was removed in 531f412, which removed
the engine package.
pkg/ioutils: deprecate NewReaderErrWrapper
It was introduced in bd130e7 as part of
docker#7542, but was never used.
pkg/ioutils: deprecate NopFlusher
Apart from being used internally for NewWriteFlusher, it's only used
in a single location outside of this package. Copy the implementation
where it's used, and mark it deprecated.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)