Skip to content

Dockerfile: update runc binary to v1.2.4#49238

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_runc_binary_1.2.4
Jan 9, 2025
Merged

Dockerfile: update runc binary to v1.2.4#49238
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_runc_binary_1.2.4

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

This is the fourth patch release of the 1.2.z release branch of runc. It includes a fix for a regression introduced in 1.2.0 related to the default device list.

  • Re-add tun/tap devices to built-in allowed devices lists.

In runc 1.2.0 we removed these devices from the default allow-list
(which were added seemingly by accident early in Docker's history) as
a precaution in order to try to reduce the attack surface of device
inodes available to most containers. At the time we thought
that the vast majority of users using tun/tap would already be
specifying what devices they need (such as by using --device with
Docker/Podman) as opposed to doing the mknod manually, and thus
there would've been no user-visible change.

Unfortunately, it seems that this regressed a noticeable number of
users (and not all higher-level tools provide easy ways to specify
devices to allow) and so this change needed to be reverted. Users
that do not need these devices are recommended to explicitly disable
them by adding deny rules in their container configuration.

full diff: opencontainers/runc@v1.2.3...v1.2.4
release notes: https://github.com/opencontainers/runc/releases/tag/v1.2.4

- What I did

- How I did it

- How to verify it

- Description for the changelog

Upgrade `runc` to [v1.2.4](https://github.com/opencontainers/runc/releases/tag/v1.2.4)

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 28.0.0 milestone Jan 8, 2025
@thaJeztah thaJeztah self-assigned this Jan 8, 2025
@thaJeztah thaJeztah requested a review from tianon as a code owner January 8, 2025 17:53
@thaJeztah thaJeztah changed the title Dockerfile: update runc binary to v1.2.3 Dockerfile: update runc binary to v1.2.4 Jan 8, 2025
This is the fourth patch release of the 1.2.z release branch of runc. It
includes a fix for a regression introduced in 1.2.0 related to the
default device list.

- Re-add tun/tap devices to built-in allowed devices lists.

 In runc 1.2.0 we removed these devices from the default allow-list
 (which were added seemingly by accident early in Docker's history) as
 a precaution in order to try to reduce the attack surface of device
 inodes available to most containers. At the time we thought
 that the vast majority of users using tun/tap would already be
 specifying what devices they need (such as by using --device with
 Docker/Podman) as opposed to doing the mknod manually, and thus
 there would've been no user-visible change.

 Unfortunately, it seems that this regressed a noticeable number of
 users (and not all higher-level tools provide easy ways to specify
 devices to allow) and so this change needed to be reverted. Users
 that do not need these devices are recommended to explicitly disable
 them by adding deny rules in their container configuration.

full diff: opencontainers/runc@v1.2.3...v1.2.4
release notes: https://github.com/opencontainers/runc/releases/tag/v1.2.4

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the bump_runc_binary_1.2.4 branch from 95936f4 to aad7bce Compare January 8, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants