Skip to content

Use bridge consts for "DefaultGatewayIPv[46]" aux-addr keys#49229

Merged
thaJeztah merged 1 commit intomoby:masterfrom
robmry:defgw_labels
Jan 8, 2025
Merged

Use bridge consts for "DefaultGatewayIPv[46]" aux-addr keys#49229
thaJeztah merged 1 commit intomoby:masterfrom
robmry:defgw_labels

Conversation

@robmry
Copy link
Copy Markdown
Contributor

@robmry robmry commented Jan 7, 2025

- What I did

Use bridge.DefaultGatewayV4AuxKey / bridge.DefaultGatewayV6AuxKey instead of the strings in the daemon code that sets up the default bridge (to make it more obvious where the keys are used).

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@robmry robmry added area/networking Networking kind/refactor PR's that refactor, or clean-up code area/networking/d/bridge Networking labels Jan 7, 2025
@robmry robmry added this to the 28.0.0 milestone Jan 7, 2025
@robmry robmry requested a review from akerouanton January 7, 2025 15:02
@robmry robmry self-assigned this Jan 7, 2025
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit eb36b18 into moby:master Jan 8, 2025
@robmry robmry deleted the defgw_labels branch January 10, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/networking/d/bridge Networking area/networking Networking kind/refactor PR's that refactor, or clean-up code status/4-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants