Skip to content

[27.x backport] Restore labels when re-creating Windows networks#49200

Merged
thaJeztah merged 1 commit intomoby:27.xfrom
robmry:backport-27.x/49179_restore_windows_network_labels
Jan 2, 2025
Merged

[27.x backport] Restore labels when re-creating Windows networks#49200
thaJeztah merged 1 commit intomoby:27.xfrom
robmry:backport-27.x/49179_restore_windows_network_labels

Conversation

@robmry
Copy link
Copy Markdown
Contributor

@robmry robmry commented Jan 2, 2025

- What I did

- How I did it

Save and restore network labels when re-creating Windows networks during daemon startup.

- How to verify it

As described in the issue ...

docker network create --label test --driver nat test
docker network inspect test. Check that the label test has been successfully added.
Restart the Windows service for the docker engine ( or restart the computer to install OS updates)
docker network inspect test. Check if the label test still exists.

- Description for the changelog

- Preserve network labels during daemon startup.

Signed-off-by: Rob Murray <[email protected]>
(cherry picked from commit 25009ed)
Signed-off-by: Rob Murray <[email protected]>
@robmry robmry added this to the 27.5.0 milestone Jan 2, 2025
@robmry robmry self-assigned this Jan 2, 2025
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robmry robmry marked this pull request as ready for review January 2, 2025 20:37
@thaJeztah thaJeztah merged commit 9cf3313 into moby:27.x Jan 2, 2025
@robmry robmry deleted the backport-27.x/49179_restore_windows_network_labels branch January 3, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants