integration-cli: migrate TestCreateByImageID to integration suite#49198
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 8, 2025
Merged
integration-cli: migrate TestCreateByImageID to integration suite#49198thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
thaJeztah
commented
Jan 2, 2025
Comment on lines
+96
to
+98
| doc: "image ID without algorithm", | ||
| image: imgID, |
Member
Author
There was a problem hiding this comment.
Looks like this is testing the same as
moby/integration-cli/docker_cli_create_test.go
Lines 306 to 312 in 58125b6
Let me remove that test, and add a comment here that it's related to #20972
thaJeztah
force-pushed
the
migrate_TestCreateByImageID
branch
from
d9b9d02 to
c6f0613
Compare
This test originally added in 4352da7, and was a bit involved as it involved building an image, and had some dubious test-cases, such as using `wrongimage:<ID of other image>` as reference, and expecting that to produce a "not found" error. Possibly this format was supported in the past, but currently it fails equally with `correctimage:<ID of image>`. This patch rewrites the test to an integration test, and removes the test from integration-cli. It also removes TestCreate64ByteHexID, as it was duplicated by this test. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
migrate_TestCreateByImageID
branch
from
c6f0613 to
a646467
Compare
vvoland
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test originally added in 4352da7,
and was a bit involved as it involved building an image, and had some
dubious test-cases, such as using
wrongimage:<ID of other image>asreference, and expecting that to produce a "not found" error. Possibly
this format was supported in the past, but currently it fails equally with
correctimage:<ID of image>.This patch rewrites the test to an integration test, and removes the test
from integration-cli. It also removes TestCreate64ByteHexID, as it was
duplicated by this test.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)