Restore labels when re-creating Windows networks#49196
Conversation
Signed-off-by: Rob Murray <[email protected]>
|
Some questions;
|
Yes, all older versions I think ... I added a cherry-pick label for 27.x, I'll add 25.0 and 26.1 too - although I'm not sure we'll want to update those.
Yes, it's a wider problem ... the test suites start their own daemon, and it's not currently possible to start another on the same host as we do for Linux. Perhaps we should have a Windows test suite that doesn't start its own daemon, so that tests can manage their own - but that's out of scope here.
Nothing jumped out at me but yes, there may be other things that get lost when these networks are re-created. If we could write an integration test for it, comparing before/after inspect outputs would be good - although it'd only catch missing attributes populated by the test. (I'm not sure how we'd write a test that could catch dropped options that don't exist yet.) |
|
I'll go ahead and merge this ... it fixes the reported problem, and we should look at improvements to regression testing infrastructure separately. |
|
Thanks! Yes, definitely fine to go otherwise. I also can't come up with an easy way to address the Windows testing situation; not having DIND available as option, and starting multiple daemons being less than trivial for sure makes some things more complicated. |
- What I did
- How I did it
Save and restore network labels when re-creating Windows networks during daemon startup.
- How to verify it
As described in the issue ...
- Description for the changelog
- Preserve network labels during daemon startup.