Skip to content

vendor: github.com/Azure/go-ansiterm faa5f7b0171c, remove workaround for OSC string terminator parsing#49195

Merged
cpuguy83 merged 2 commits intomoby:masterfrom
thaJeztah:vendor_ansiterm
Jan 2, 2025
Merged

vendor: github.com/Azure/go-ansiterm faa5f7b0171c, remove workaround for OSC string terminator parsing#49195
cpuguy83 merged 2 commits intomoby:masterfrom
thaJeztah:vendor_ansiterm

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

relates to:

vendor: github.com/Azure/go-ansiterm faa5f7b0171c

  • Fix OSC string terminator parsing

full diff: Azure/go-ansiterm@306776e...faa5f7b

daemon/logger/loggertest: remove workaround for OSC string terminator parsing

This workaround was added in 2ec3e14
to work around a bug in go-ansiterm, which was fixed in o-ansiterm#35.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

- Fix OSC string terminator parsing

full diff:  Azure/go-ansiterm@306776e...faa5f7b

Signed-off-by: Sebastiaan van Stijn <[email protected]>
… parsing

This workaround was added in 2ec3e14
to work around a [bug in go-ansiterm][1], which was fixed in [o-ansiterm#35][1].

[1]: Azure/go-ansiterm#34
[2]: Azure/go-ansiterm#35

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member Author

@corhere @vvoland does the fix also fix #43710 ?

@cpuguy83 cpuguy83 merged commit db6158b into moby:master Jan 2, 2025
@thaJeztah thaJeztah deleted the vendor_ansiterm branch January 2, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants