pkg/sysinfo: internalize parsing cpusets#49193
Merged
thaJeztah merged 5 commits intomoby:masterfrom Jan 6, 2025
Merged
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
AkihiroSuda
reviewed
Jan 5, 2025
| return false, err | ||
| } | ||
| // Start with the normal maximum number of CPUs on Linux, but accept | ||
| // more if we actually have more CPUs available. |
Member
There was a problem hiding this comment.
What is the point of having this maxCPUs variable?
Member
Author
There was a problem hiding this comment.
I had to dig in history a bit, but It was added in f8e876d;
Related CVE was CVE-2018-20699, with some discussion here; docker-archive#70 (comment)
Member
Author
There was a problem hiding this comment.
Let me add that to the comment
AkihiroSuda
approved these changes
Jan 5, 2025
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
internalize_pkg_parsers
branch
from
e3653f9 to
2282279
Compare
thaJeztah
commented
Jan 6, 2025
Comment on lines
+329
to
+338
| // | ||
| // This limit was added in f8e876d7616469d07b8b049ecb48967eeb8fa7a5 | ||
| // to address CVE-2018-20699: | ||
| // | ||
| // Using a value such as `--cpuset-mems=1-9223372036854775807` would cause | ||
| // dockerd to run out of memory allocating a map of the values in the | ||
| // validation code. Set limits to the normal limit of the number of CPUs. | ||
| // | ||
| // More details in https://github.com/docker-archive/engine/pull/70#issuecomment-458458288 | ||
| maxCPUs := defaultMaxCPUs |
Member
Author
There was a problem hiding this comment.
Added a comment here to link to the relevant information
robmry
approved these changes
Jan 6, 2025
This was referenced Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/pkg#32989- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)