daemon: don't repeatedly call NumCPU if not needed#49192
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 2, 2025
Merged
daemon: don't repeatedly call NumCPU if not needed#49192thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
sysinfo.NumCPU returns the number of CPUs which are currently online, which involves some syscalls and parsing on Windows. Change the code to only retrieve this information when needed, and memoize the result to prevent calling this function multiple times. Ideally, we'd obtain this information from daemon.RawSysInfo(), but that uses a sync.Once, which could return outdated information. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/daemon
robmry
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sysinfo.NumCPU returns the number of CPUs which are currently online, which involves some syscalls and parsing on Windows.
Change the code to only retrieve this information when needed, and memoize the result to prevent calling this function multiple times.
Ideally, we'd obtain this information from daemon.RawSysInfo(), but that uses a sync.Once, which could return outdated information.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)