daemon: adjust tests for changes in go1.24 JSON errors#49188
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 1, 2025
Merged
daemon: adjust tests for changes in go1.24 JSON errors#49188thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
These tests failed because the error message changed in go1.24 through https://go.dev/cl/606956. === Failed === FAIL: daemon/config TestDaemonConfigurationFeatures/invalid_config_value (0.00s) config_linux_test.go:182: assertion failed: expected error "json: cannot unmarshal string into Go struct field Config.features of type bool", got "json: cannot unmarshal string into Go struct field Config.CommonConfig.features of type bool" === FAIL: daemon/config TestDaemonConfigurationFeatures (0.00s) === FAIL: daemon/config TestDaemonConfigurationHostGatewayIP/config_not_array (0.00s) config_linux_test.go:354: assertion failed: expected error "json: cannot unmarshal string into Go struct field Config.host-gateway-ips of type []netip.Addr", got "json: cannot unmarshal string into Go struct field Config.CommonConfig.DNSConfig.host-gateway-ips of type []netip.Addr" Relax the tests a bit to accept errors produced by either go1.24 or older. Signed-off-by: Sebastiaan van Stijn <[email protected]>
AkihiroSuda
approved these changes
Jan 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests failed because the error message changed in go1.24 through https://go.dev/cl/606956.
Relax the tests a bit to accept errors produced by either go1.24 or older.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)