daemon: minor cleanups for getting system info#49185
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 1, 2025
Merged
Conversation
thaJeztah
added
status/2-code-review
area/daemon
AkihiroSuda
approved these changes
Jan 1, 2025
thaJeztah
commented
Jan 1, 2025
| memInfo, err := meminfo.Read() | ||
| mi, err := meminfo.Read() | ||
| if err != nil { | ||
| log.G(ctx).Errorf("Could not read system memory info: %v", err) |
Member
Author
There was a problem hiding this comment.
Oh! Looks like I missed one; let me update this one as well while I'm at it 🙈
thaJeztah
force-pushed
the
daemon_info_cleanups
branch
from
f077112 to
c383642
Compare
- rename variables that shadowed functions - use strconv.FormatBool instead of fmt.Sprintf to reduce some allocations - use structured logs for some warnings - remove some intermediate vars in favor of early returns Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
daemon_info_cleanups
branch
from
c383642 to
aa7493f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- A picture of a cute animal (not mandatory but encouraged)