pkg/chrootarchive: use stdlib errors, remove "// import" comments#49151
Merged
AkihiroSuda merged 2 commits intomoby:masterfrom Dec 20, 2024
Merged
pkg/chrootarchive: use stdlib errors, remove "// import" comments#49151AkihiroSuda merged 2 commits intomoby:masterfrom
AkihiroSuda merged 2 commits intomoby:masterfrom
Conversation
Remove use of github.com/pkg/errors for this package, in preparation of it being moved to a separate module. Signed-off-by: Sebastiaan van Stijn <[email protected]>
These comments were added to prevent users from accidentally importing using the wrong module name, but they don't have an effect when working in go modules mode. Remove the comments in preparation of moving this package to a separate module. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
AkihiroSuda
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
/pkg#32989pkg/archiveout of main module/repository #49069pkg/chrootarchive: use stdlib errors
Remove use of github.com/pkg/errors for this package, in preparation
of it being moved to a separate module.
pkg/chrootarchive: remove "// import" comments
These comments were added to prevent users from accidentally
importing using the wrong module name, but they don't have
an effect when working in go modules mode.
Remove the comments in preparation of moving this package
to a separate module.
- A picture of a cute animal (not mandatory but encouraged)