Conversation
…GC policy Signed-off-by: David Karlsson <[email protected]> (cherry picked from commit b08ff81) Signed-off-by: Sebastiaan van Stijn <[email protected]>
vvoland
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit b08ff81)
- What I did
Builder GC policies without a
keepStorageoption set should fall back to using thedefaultKeepStoragevalue. But currently, the policy'skeepStorageis parsed unconditionally, meaning that if it's unset, an error occurs:The only way to get a policy to use
defaultKeepStoragelimit for GC would be to set it to"0".This patch is to make sure policy
keepStorageis conditionally parsed, if set, otherwise thedefaultKeepStorageis used.I also modified related error messages:
- How I did it
- How to verify it
Tested manually;
{ "builder": { "gc": { "enabled": true, "defaultKeepStorage": "10GB", "policy": [ { "filter": ["unused-for=2200h"] } ] } } }- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)