image: Remove GetImageManifest#49133
Merged
thaJeztah merged 2 commits intomoby:masterfrom Dec 19, 2024
Merged
Conversation
vvoland
added
status/2-code-review
area/images
Its only usage was in container creation, which also called `GetImage` first. This method is specific to the containerd image service and is largely the same as `GetImage`, except it returns a manifest descriptor. Instead, introduce add the descriptor as a new field in `Image.Details` and set it in the containerd image service implementation of `GetImage`. Signed-off-by: Paweł Gronowski <[email protected]>
Last usage of these fields was removed by cd11843. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
c8d-remove-getimagemanifest
branch
from
885f6cf to
c452af6
Compare
Member
|
Some timeouts in networking unit tests; posting in case these became flaky Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its only usage was in container creation, which also called
GetImagefirst.This method is specific to the containerd image service and is largely the same as
GetImage, except it returns a manifest descriptor. Instead, introduce add the descriptor as a new field inImage.Detailsand set it in the containerd image service implementation ofGetImage.- A picture of a cute animal (not mandatory but encouraged)