Enable external DNS if a network has an IPv6 gateway#49128
Merged
thaJeztah merged 1 commit intomoby:masterfrom Dec 18, 2024
Merged
Enable external DNS if a network has an IPv6 gateway#49128thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Rob Murray <[email protected]>
akerouanton
approved these changes
Dec 18, 2024
Contributor
Author
|
Unrelated Windows test failure ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Make sure external DNS is enabled for an IPv6-only network with external access.
(No backport needed, this only affects the new IPv6-only networks.)
- How I did it
The function that checked whether a network has external access only looked for an IPv4 gateway, or IPv4/IPv6 static routes... it didn't understand the new IPv6-only networks.
- How to verify it
New integration test, fails without the fix.
- Description for the changelog