Skip to content

Enable external DNS if a network has an IPv6 gateway#49128

Merged
thaJeztah merged 1 commit intomoby:masterfrom
robmry:v6only/enable_ext_dns
Dec 18, 2024
Merged

Enable external DNS if a network has an IPv6 gateway#49128
thaJeztah merged 1 commit intomoby:masterfrom
robmry:v6only/enable_ext_dns

Conversation

@robmry
Copy link
Copy Markdown
Contributor

@robmry robmry commented Dec 18, 2024

- What I did

Make sure external DNS is enabled for an IPv6-only network with external access.

(No backport needed, this only affects the new IPv6-only networks.)

- How I did it

The function that checked whether a network has external access only looked for an IPv4 gateway, or IPv4/IPv6 static routes... it didn't understand the new IPv6-only networks.

- How to verify it

New integration test, fails without the fix.

- Description for the changelog

@robmry robmry added area/networking Networking kind/bugfix PR's that fix bugs area/networking/ipv6 Networking area/networking/dns Networking labels Dec 18, 2024
@robmry robmry added this to the 28.0.0 milestone Dec 18, 2024
@robmry robmry self-assigned this Dec 18, 2024
@robmry robmry requested a review from akerouanton December 18, 2024 12:29
@robmry
Copy link
Copy Markdown
Contributor Author

robmry commented Dec 18, 2024

Unrelated Windows test failure ...

=== FAIL: github.com/docker/docker/integration-cli TestDockerCLIRunSuite/TestRunTwoConcurrentContainers (60.34s)
    docker_cli_run_test.go:813: assertion failed: error is not nil: 
        Command:  D:\a\moby\moby\out\docker.exe run busybox sleep 2
        ExitCode: 125
        Error:    exit status 125
        Stdout:   
        Stderr:   D:\a\moby\moby\out\docker.exe: error during connect: Post http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.30/containers/create: EOF.
        See 'D:\a\moby\moby\out\docker.exe run --help'.
        
        
        Failures:
        ExitCode was 125 expected 0
        Expected no error

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 93101be into moby:master Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/networking/dns Networking area/networking/ipv6 Networking area/networking Networking kind/bugfix PR's that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants