[master forward-port] libnet: don't put external DNS answers in OTel spans#49123
Merged
thaJeztah merged 1 commit intomoby:masterfrom Dec 18, 2024
Merged
Conversation
When containers make DNS resolution, and the domain name they're trying to resolve doesn't match any running container, the DNS query is forwarded to upstream servers. In that case, when we receive a response, we put it in an OTel spans. This was useful to debug DNS resolution on GHA, but it leads to excessive memory usage when DNS resolution happen in a tight loop. So, keep the OTel event signaling that a response was received, but drop the answer from the OTel span. Signed-off-by: Albin Kerouanton <[email protected]> (cherry picked from commit 173a9f2) Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added
status/2-code-review
area/networking
thaJeztah
changed the title
robmry
approved these changes
Dec 18, 2024
thaJeztah
approved these changes
Dec 18, 2024
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
I guess in hindsight we should've done master first.
I'll update this PR description after merging to add a link to the related tracking ticket
robmry
added
impact/changelog
process/cherry-picked
and removed
impact/changelog
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
When containers make DNS resolution, and the domain name they're trying to resolve doesn't match any running container, the DNS query is forwarded to upstream servers. In that case, when we receive a response, we put it in an OTel spans.
This was useful to debug DNS resolution on GHA, but it leads to excessive memory usage when DNS resolution happen in a tight loop. So, keep the OTel event signaling that a response was received, but drop the answer from the OTel span.
(cherry picked from commit 173a9f2)
- Description for the changelog
- Fix an issue that caused excessive memory usage when DNS resolution was made in a tight loop