pkg/system: deprecate types and functions that are only used internally#49098
Merged
thaJeztah merged 1 commit intomoby:masterfrom Dec 16, 2024
Merged
pkg/system: deprecate types and functions that are only used internally#49098thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
impact/deprecation
area/go-sdk
impact/go-sdk
These types and functions are only used internally (through pkg/archive). Deprecate them, and mark them for removal. This deprecates the `Lstat()`, `Mkdev()`, `Mknod()`, `FromStatT()` and `Stat()` functions, and related `StatT` type. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
deprecate_pkg_system
branch
from
3f37aaa to
f0ce367
Compare
Member
Author
|
Flaky test; tracked in #48881 |
vvoland
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These types and functions are only used internally (through pkg/archive). Deprecate them, and mark them for removal.
This deprecates the
Lstat(),Mkdev(),Mknod(),FromStatT()andStat()functions, and relatedStatTtype.- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)