libnet/d/bridge: unconditionally error out if LinkSetMTU fails#49092
Merged
thaJeztah merged 1 commit intomoby:masterfrom Dec 14, 2024
Merged
libnet/d/bridge: unconditionally error out if LinkSetMTU fails#49092thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
akerouanton
added
status/2-code-review
area/networking
akerouanton
changed the title
akerouanton
force-pushed
the
dont-ignore-linksetmtu-error
branch
from
13cf2a2 to
99cb0cb
Compare
Since 89470a7 we ignore errors returned by `LinkSetMTU` when the MTU is greater than 1500 but lower than 65535 to let CentOS/RHEL 7 users set an MTU in that range (despite their kernel rejecting that value). We dropped support for those distros, so we can now remove this code and unconditionally error out if `LinkSetMTU` returns an error. Commit 89470a7 introduced two unit tests - these are kept, and both now have a proper GoDoc describing what they're testing. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
force-pushed
the
dont-ignore-linksetmtu-error
branch
from
99cb0cb to
678ef1a
Compare
Member
|
Bonus points; this fixes #47312 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
- What I did
Since 89470a7 we ignore errors returned by
LinkSetMTUwhen the MTU is greater than 1500 but lower than 65535 to let CentOS/RHEL 7 users set an MTU in that range (despite their kernel rejecting that value).We dropped support for those distros, so we can now remove this code and unconditionally error out if
LinkSetMTUreturns an error.Commit 89470a7 introduced two unit tests - these are kept, and both now have a proper GoDoc describing what they're testing.
- How to verify it
Existing unit tests.