Dockerfile: remove dpkg-dev, libudev-dev, libsecret-1-dev, libbtrfs-dev dependencies#49067
Merged
thaJeztah merged 4 commits intomoby:masterfrom Dec 12, 2024
Merged
Conversation
thaJeztah
added
status/2-code-review
area/packaging
kind/refactor
We don't build .deb packages as part of the Dockerfiles in this repository, so we can remove this dependency. Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was introduced in e89a5e5, and probably used for devicemapper, which we no longer support, so likely unused. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This dependency was added in 81d704d, but I could not find a reference to it, and we may not need it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_build_deps_step2
branch
from
c4cdcc3 to
7d79b30
Compare
thaJeztah
commented
Dec 11, 2024
| @@ -210,7 +210,6 @@ RUN --mount=type=cache,sharing=locked,id=moby-containerd-aptlib,target=/var/lib/ | |||
| apt-get update && xx-apt-get install -y --no-install-recommends \ | |||
| gcc \ | |||
| libbtrfs-dev \ | |||
Member
Author
There was a problem hiding this comment.
this one should also be redundant now, as we're now on containerd 1.7, which no longer uses this;
Starting with [containerd@52f82ac] (containerd 1.7), this dependency is no longer needed for building containerd. [containerd@52f82ac]: containerd/containerd@52f82ac Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
p1-0tr
approved these changes
Dec 12, 2024
vvoland
approved these changes
Dec 12, 2024
laurazard
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfile: remove dpkg-dev dependency
We don't build .deb packages as part of the Dockerfiles in this
repository, so we can remove this dependency.
Dockerfile: remove libudev-dev dependency
It was introduced in e89a5e5, and probably
used for devicemapper, which we no longer support, so likely unused.
Dockerfile: remove libsecret-1-dev dependency
This dependency was added in 81d704d, but
I could not find a reference to it, and we may not need it.
Dockerfile: remove libbtrfs-dev dependency
Starting with containerd@52f82ac (containerd 1.7), this dependency is no
longer needed for building containerd.
- A picture of a cute animal (not mandatory but encouraged)