integration-cli: don't skip AppArmor tests on SLES#49061
integration-cli: don't skip AppArmor tests on SLES#49061thaJeztah merged 1 commit intomoby:masterfrom
Conversation
This partially reverts e440831 ("fix and skip some tests based on API version"), which caused the integration-cli tests to skip all AppArmor-related tests on SUSE. It's not really clear why this was done originally, but I have verified that on modern SLE 12 and SLE 15 systems the AppArmor tests pass without any adjustments needed. Signed-off-by: Aleksa Sarai <[email protected]>
Hm.. good one; I think that must've been related to docker enterprise which ISTR had to provide support for some very legacy version of SLES, so possibly(?) there was an issue in that version? I want to look at some of the other changes in that PR though (#37003). If memory serves me well, those changes were related to an internal pipeline that was being set up to compile the integration tests and run them against various combinations of the daemon (and CLI). Looking at those changes though, there's some tests being excluded for API > 1.30, however the integration-cli suite is frozen (i.e., no new tests to be added that depend on the CLI, and instead test the API in this repository) and uses a fixed version (17.06) of the CLI. That version of the CLI only supports API 1.30 and older, so there should be no tests in there that depend on newer API versions 🤔 |
3 participants
This partially reverts e440831 ("fix and skip some tests based on
API version"), which caused the integration-cli tests to skip all
AppArmor-related tests on SUSE.
It's not really clear why this was done originally, but I have verified
that on modern SLE 12 and SLE 15 systems the AppArmor tests pass without
any adjustments needed.
Signed-off-by: Aleksa Sarai [email protected]