api/types/network: add godoc for EndpointSettings.GwPriority#49045
Merged
thaJeztah merged 1 commit intomoby:masterfrom Dec 8, 2024
Merged
api/types/network: add godoc for EndpointSettings.GwPriority#49045thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
This field was introduced in 5b752fa, which added documentation in the API documentation (swagger), but did not document the field in the API go types. This patch adds documentation, using a variant of the description used in swagger. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/api
austinvazquez
approved these changes
Dec 7, 2024
Member
Author
|
Let me bring this one in; text was already reviewed in the other PR; this is just making sure the code is also documented. |
Member
|
Good catch! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This field was introduced in 5b752fa, which added documentation in the API documentation (swagger), but did not document the field in the API go types.
This patch adds documentation, using a variant of the description used in swagger.